Include parentheses in n_ARRAY_VALUE_LIST node
d052c489a283
Actions

Authored by Joshua Spence <josh@joshuaspence.com> on Aug 11 2015, 12:52.

Description

Include parentheses in n_ARRAY_VALUE_LIST node

Summary: Currently parsing array(1, 2, 3) results in a n_ARRAY_VALUE_LIST with a concrete string of 1, 2, 3. Compare this to list($x, $y) which results in a n_ASSIGNMENT_LIST with a concrete string of ($x, $y).

Test Plan: See next diff.

Reviewers: #blessed_reviewers, epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D13858

Details

Committed

Joshua Spence <josh@joshuaspence.com>

Aug 11 2015, 14:32

Pushed

aubort

Mar 17 2017, 12:03

Parents

rPHUf26954065e59: Use the configuration driven unit test engine

Branches

Unknown

Tags

Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rPHUd052c489a283: Include parentheses in n_ARRAY_VALUE_LIST node (authored by Joshua Spence <josh@joshuaspence.com>).Aug 11 2015, 14:32

Changes (8)

				Path
	M			src/parser/xhpast/__tests__/data/php-array-dereference.expect
	M			src/parser/xhpast/__tests__/data/php-literal-index.php.expect
	M			src/parser/xhpast/__tests__/data/php-short-array.php.expect
	M			src/parser/xhpast/__tests__/data/php-syntax.php.expect
	M			src/parser/xhpast/bin/PhutilXHPASTBinary.php
	M			support/xhpast/parser.y
	M			support/xhpast/parser.yacc.cpp
	M			support/xhpast/xhpast.cpp