Homec4science

Make Phage agents stream output continuously

Authored by epriestley <git@epriestley.com> on Feb 17 2017, 23:11.

Description

Make Phage agents stream output continuously

Summary:
Ref T2794. Currently, the Phage agent waits until the remote command completes before sending output back to the controller.

Instead, stream output continuously.

Also work around some kind of weirdness with error reporting that I hit but couldn't immediately figure out (maybe PHP7-related?).

Test Plan: Ran bin/phage remote --hosts ... upgrade, etc., and saw a steady stream of output across multiple hosts.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T2794

Differential Revision: https://secure.phabricator.com/D17378

Details

Committed
epriestley <git@epriestley.com>Feb 18 2017, 01:57
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU9f66fbd018f1: In PhutilLogFileChannel, don't log empty messages
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUd09e94e4b94a: Make Phage agents stream output continuously (authored by epriestley <git@epriestley.com>).Feb 18 2017, 01:57