Homec4science

Fix an issue where resolveKill() emits a warning if the future was never started

Authored by epriestley <git@epriestley.com> on Feb 14 2017, 16:14.

Description

Fix an issue where resolveKill() emits a warning if the future was never started

Summary:
Ref T2794. This is a minor warning I hit while exploring Phage stuff. In Phage, we can resolveKill() a future that we never called start() on, which tries to proc_terminate() a process which never spawned. This emits a warning.

Instead, check that $this->proc exists before signaling it.

Test Plan: Added a unit test.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T2794

Differential Revision: https://secure.phabricator.com/D17354

Details

Committed
epriestley <git@epriestley.com>Feb 14 2017, 16:26
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU82f71f62129b: Don't stem "words" with a "." or "_" in them
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUd37145bd144e: Fix an issue where resolveKill() emits a warning if the future was never started (authored by epriestley <git@epriestley.com>).Feb 14 2017, 16:26