Homec4science

Remove Exception typehint to fix T9637

Authored by Michael Krasnow <mnkras@gmail.com> on Oct 26 2015, 19:34.

Description

Remove Exception typehint to fix T9637

Summary:
Parse errors are caught by the error handler in PHP7, but they may not be of the type Exception
Remove type-hinting so that we can catch them and deal with them

Test Plan: arc unit --everything

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Maniphest Tasks: T9637

Differential Revision: https://secure.phabricator.com/D14342

Details

Committed
Michael Krasnow <mnkras@gmail.com>Oct 26 2015, 19:34
Pushed
aubortMar 17 2017, 12:03
Parents
rPHUfe7d8c21a808: Improve UTF8StringTruncator behavior for huge inputs
Branches
Unknown
Tags
Unknown

Event Timeline

Michael Krasnow <mnkras@gmail.com> committed rPHUd5b4421792e5: Remove Exception typehint to fix T9637 (authored by Michael Krasnow <mnkras@gmail.com>).Oct 26 2015, 19:34