Don't eat whitespace after T_OPEN_TAG
dc0626970a6d
Actions

Authored by Joshua Spence <josh@freelancer.com> on Aug 30 2015, 22:49.

Description

Don't eat whitespace after T_OPEN_TAG

Summary: Currently the scanner eats whitespace after <?php but not after <?. This means that <?php tokenises to T_OPEN_TAG (see https://secure.phabricator.com/xhpast/view/853/) whereas <? tokenises to T_OPEN_TAG, T_WHITESPACE (see https://secure.phabricator.com/xhpast/view/854/).

Test Plan:

Before	After
{F764333}	{F764335}

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Committed

Joshua Spence <josh@freelancer.com>

Aug 30 2015, 22:49

Pushed

aubort

Mar 17 2017, 12:03

Parents

rPHUc8a008f7e46c: Make PHP echo tags always available

Branches

Unknown

Tags

Unknown

Joshua Spence <josh@freelancer.com> committed rPHUdc0626970a6d: Don't eat whitespace after T_OPEN_TAG (authored by Joshua Spence <josh@freelancer.com>).Aug 30 2015, 22:49

				Path
	M			src/parser/xhpast/__tests__/data/base-pass.php.expect
	M			src/parser/xhpast/__tests__/data/php-access-on-instanciation.expect
	M			src/parser/xhpast/__tests__/data/php-array-dereference-2.expect
	M			src/parser/xhpast/__tests__/data/php-array-dereference-3.expect
	M			src/parser/xhpast/__tests__/data/php-array-dereference.expect
	M			src/parser/xhpast/__tests__/data/php-binary-literal.php.expect
	M			src/parser/xhpast/__tests__/data/php-callable-typehint.php.expect
	M			src/parser/xhpast/__tests__/data/php-comments.php.expect
	M			src/parser/xhpast/__tests__/data/php-empty-heredoc.php.expect
	M			src/parser/xhpast/__tests__/data/php-finally.php.expect
	M			src/parser/xhpast/__tests__/data/php-literal-index.php.expect
	M			src/parser/xhpast/__tests__/data/php-literals.php.expect
	M			src/parser/xhpast/__tests__/data/php-short-array.php.expect
	M			src/parser/xhpast/__tests__/data/php-syntax.php.expect
	M			src/parser/xhpast/__tests__/data/php-tags.php.expect
	M			src/parser/xhpast/__tests__/data/php-traits.php.expect
	M			src/parser/xhpast/__tests__/data/php-yield.php.expect
	M			src/parser/xhpast/bin/PhutilXHPASTBinary.php
	M			support/xhpast/scanner.l
	M			support/xhpast/scanner.lex.cpp
	M			support/xhpast/scanner.lex.hpp
	M			support/xhpast/xhpast.cpp