Homec4science

Simplify ignoring case in lexer

Authored by vrana <jakubv@fb.com> on Aug 22 2012, 23:05.

Description

Simplify ignoring case in lexer

Summary:
I like the expressiveness of regexps.
Plus almost everything is case insensitive in PHP, it was hard to find something which is not for the test case.

Also added more case insensitive checks and included 'S' flag mentioned at D3336#7.
Also used identifier pattern in function definition.

Test Plan: New test case.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3366

Details

Committed
vrana <jakubv@fb.com>Aug 22 2012, 23:41
Pushed
aubortMar 17 2017, 12:03
Parents
rPHUb30fde1853e8: Build a PhutilLexer-based highlighter
Branches
Unknown
Tags
Unknown

Event Timeline

vrana <jakubv@fb.com> committed rPHUe2449a6057ab: Simplify ignoring case in lexer (authored by vrana <jakubv@fb.com>).Aug 22 2012, 23:41