Homec4science

Add Filesystem::binaryExists()

Authored by epriestley <git@epriestley.com> on May 19 2013, 02:05.

Description

Add Filesystem::binaryExists()

Summary:
We use which x in various places; provide a wrapper which we might some day make work on Windows.

The motivation for this is twofold:

  • I want to commandeer D5670, which will involve another which. which is yuck.
  • Users hit issues with svn, git, etc., fairly often. It would be good to do a check after hitting an error in PhabricatorRepository so we can raise a very specific error message about "you do not have git in your webserver path, here is how to fix that".

Test Plan: Ummm... will use in next diff?

Reviewers: btrahan, vrana

Reviewed By: vrana

CC: aran

Differential Revision: https://secure.phabricator.com/D5968

Details

Committed
epriestley <git@epriestley.com>May 19 2013, 02:05
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU3e07dbde7d46: Fix calculation of spritesheet hashes to use relative paths
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUe4ad3b818cab: Add Filesystem::binaryExists() (authored by epriestley <git@epriestley.com>).May 19 2013, 02:05