Add support in XHPAST for "(new X)->y" syntax (added in 5.4)
e719f331aa1a
Actions

Authored by Eric Stern <eric@ericstern.com> on Feb 5 2014, 22:32.

Description

Add support in XHPAST for "(new X)->y" syntax (added in 5.4)

Summary: Ref T4334. Allows XHPAST to parse the access-on-instanciation grammar added in 5.4 Refactors some of the other grammar to be closer to Zend's parser. Adds positive and negative tests for allowed syntax.

Test Plan:
arc unit
Ran generate_php_symbols.php script on files that previously errored out with "unexpected T_OBJECT_OPERATOR", now there are no errors

Reviewers: epriestley, btrahan, #blessed_reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Maniphest Tasks: T4334

Differential Revision: https://secure.phabricator.com/D8150

Details

Committed

epriestley <git@epriestley.com>

Feb 5 2014, 22:32

Pushed

aubort

Mar 17 2017, 12:03

Parents

rPHUae84814b1688: Allow PHPAST to evalStatic() an n_CONCATENATION_LIST of static nodes

Branches

Unknown

Tags

Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUe719f331aa1a: Add support in XHPAST for "(new X)->y" syntax (added in 5.4) (authored by Eric Stern <eric@ericstern.com>).Feb 5 2014, 22:32

Changes (10)

				Path
	A			src/parser/xhpast/__tests__/data/php-access-on-instanciation-invalid.test
	A			src/parser/xhpast/__tests__/data/php-access-on-instanciation.expect
	A			src/parser/xhpast/__tests__/data/php-access-on-instanciation.test
	M			src/parser/xhpast/bin/xhpast_parse.php
	M			support/xhpast/parser.y
	M			support/xhpast/parser.yacc.cpp
	M			support/xhpast/parser.yacc.hpp
	M			support/xhpast/scanner.lex.cpp
	M			support/xhpast/scanner.lex.hpp
	M			support/xhpast/xhpast.cpp