Homec4science

Fix an RRULE issue with month days at the end of the month

Authored by epriestley <git@epriestley.com> on Sep 28 2016, 00:29.

Description

Fix an RRULE issue with month days at the end of the month

Summary:
Ref T10747. I'm porting unit tests from other implementations until I hit one that fails.

The "yearly event on Feb 29th" test failed because we assumed every month had a 29th. Instead, test if the current month has a 29th.

We were also using cursorX instead of stateX in a couple places. They often have the same value, but stateX is the correct value when they differ.

Test Plan: Unit tests now pass.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10747

Differential Revision: https://secure.phabricator.com/D16605

Details

Committed
epriestley <git@epriestley.com>Sep 28 2016, 14:30
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU5e5ae77b462b: Validate various RRULE components and simplify logic slightly
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUe7ff546372db: Fix an RRULE issue with month days at the end of the month (authored by epriestley <git@epriestley.com>).Sep 28 2016, 14:30