Homec4science

Plug memory leak with PhutilErrorTrap

Authored by epriestley <git@epriestley.com> on Aug 20 2013, 22:56.

Description

Plug memory leak with PhutilErrorTrap

Summary:
Since PhutilErrorTrap registers itself with PhutilErrorHandler, it still has a positive refcount after unset() and is not destroyed. Destroy it explicitly.

(I didn't test this well in the original revision. :/)

Test Plan: Ran phd debug phabricatorbot <config> -- --trace-memory and saw climbing memory usage before this patch. After this patch, saw steady usage.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran, staticshock

Differential Revision: https://secure.phabricator.com/D6788

Details

Committed
epriestley <git@epriestley.com>Aug 20 2013, 22:56
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU94cecd5c6fc2: Provide PhutilErrorTrap, for enriching errors generated by native PHP functions
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUeef230eaccc6: Plug memory leak with PhutilErrorTrap (authored by epriestley <git@epriestley.com>).Aug 20 2013, 22:56