Homec4science

In Phage, don't sit in a loop once we've read all messages from an agent

Authored by epriestley <git@epriestley.com> on Feb 19 2017, 16:01.

Description

In Phage, don't sit in a loop once we've read all messages from an agent

Summary: Ref T2794. The logic is intended to read "loop until we're done processing messages", but is currently missing a break;. This doesn't affect behavior yet, just makes us eat way too much CPU.

Test Plan: Saw time phage remote --hosts db001-16 status drop from 99% CPU time to <10%.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T2794

Differential Revision: https://secure.phabricator.com/D17387

Details

Committed
epriestley <git@epriestley.com>Feb 19 2017, 19:55
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU567e7fb929cd: Record command exit status on Execute objects in Phage
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUef580c9ccc21: In Phage, don't sit in a loop once we've read all messages from an agent (authored by epriestley <git@epriestley.com>).Feb 19 2017, 19:55