Homec4science

Fix infinite loop in PhutilFileTree

Authored by Peng Li <pengli@fb.com> on Jan 29 2014, 19:04.

Description

Fix infinite loop in PhutilFileTree

Summary: In one of our diff we have files with name '10.8' and '10.80' in the same dir, which caused infinite loop since numerically they are the same hence getNextSibling() call on 10.80 will always gets itself.

Test Plan: Load the diff with fix.

Reviewers: epriestley, lifeihuang, JoelB, cdentel, #blessed_reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D8091

Details

Committed
epriestley <git@epriestley.com>Jan 29 2014, 19:04
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU54dbec7ac274: Fixed missing symbols
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUf12025abc05b: Fix infinite loop in PhutilFileTree (authored by Peng Li <pengli@fb.com>).Jan 29 2014, 19:04