Homec4science

Don't leak $root when initializing libphutil scripts

Authored by epriestley <git@epriestley.com> on Mar 22 2012, 23:42.

Description

Don't leak $root when initializing libphutil scripts

Summary: We leak the global variable $root into the including context, which can ruin things. Put the whole thing in a function.

Test Plan: Ran arc, mail_handler.php.

Reviewers: Makinde, btrahan

Reviewed By: Makinde

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1997

Details

Committed
epriestley <git@epriestley.com>Mar 22 2012, 23:42
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU20b7d25debbf: Add support for HTTP headers to HTTPSFuture
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUf20864131a6e: Don't leak $root when initializing libphutil scripts (authored by epriestley <git@epriestley.com>).Mar 22 2012, 23:42