Homec4science

Distinguish more carefully between different kinds of MySQL connection errors

Authored by epriestley <git@epriestley.com> on Jan 21 2016, 21:25.

Description

Distinguish more carefully between different kinds of MySQL connection errors

Summary:
Ref T10195. Root issue: if the MySQL user doesn't have permission to access all the databases, we give them a fairly generic error instead of telling them exactly what's wrong.

Currently, we throw a generic exception on connection failure. Instead, throw a more granular one, and distinguish between bad credentials and no access.

Test Plan: See next revision.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10195

Differential Revision: https://secure.phabricator.com/D15078

Details

Committed
epriestley <git@epriestley.com>Jan 21 2016, 22:05
Pushed
aubortMar 17 2017, 12:03
Parents
rPHUb4edc1af066d: Give PhutilRope and LinesOfALarge a couple new capabilities
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUf43291e99d36: Distinguish more carefully between different kinds of MySQL connection errors (authored by epriestley <git@epriestley.com>).Jan 21 2016, 22:05