Make error handling for ICS parsing more robust
f8af794b2135
Actions

Authored by epriestley <git@epriestley.com> on Sep 8 2016, 23:41.

Description

Make error handling for ICS parsing more robust

Summary:
Ref T10747. This mostly adds a bunch of test cases for the ICS format syntax errors, and fixes a couple of issues:

Multiple VCALENDAR sections in one .ics file is legal according to the spec.
Had some bugs with parsing properties with multiple parameters.
Tighten up the regexp for property names.
Show a lot more detail about what went wrong when parsing fails.

Test Plan: Ran unit tests.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10747

Committed

epriestley <git@epriestley.com>

Sep 12 2016, 16:22

Pushed

aubort

Mar 17 2017, 12:03

Parents

rPHU0107c187b6d8: Add a very basic ICS syntax parser

Branches

Unknown

Tags

Unknown

epriestley <git@epriestley.com> committed rPHUf8af794b2135: Make error handling for ICS parsing more robust (authored by epriestley <git@epriestley.com>).Sep 12 2016, 16:22

				Path
	M			src/__phutil_library_map__.php
	M			src/parser/calendar/data/PhutilCalendarRawNode.php
	A			src/parser/calendar/data/PhutilCalendarRootNode.php
	M			src/parser/calendar/ics/PhutilICSParser.php
	A			src/parser/calendar/ics/PhutilICSParserException.php
	M			src/parser/calendar/ics/__tests__/PhutilICSParserTestCase.php
	A			src/parser/calendar/ics/__tests__/data/err-bad-base64.ics
	A			src/parser/calendar/ics/__tests__/data/err-bad-boolean.ics
	A			src/parser/calendar/ics/__tests__/data/err-extra-end.ics
	A			src/parser/calendar/ics/__tests__/data/err-initial-unfold.ics
	A			src/parser/calendar/ics/__tests__/data/err-malformed-double-quote.ics
	A			src/parser/calendar/ics/__tests__/data/err-malformed-parameter.ics
	A			src/parser/calendar/ics/__tests__/data/err-malformed-property.ics
	A			src/parser/calendar/ics/__tests__/data/err-missing-end.ics
	A			src/parser/calendar/ics/__tests__/data/err-missing-value.ics
	A			src/parser/calendar/ics/__tests__/data/err-mixmatched-sections.ics
	A			src/parser/calendar/ics/__tests__/data/err-root-property.ics
	A			src/parser/calendar/ics/__tests__/data/err-unescaped-backslash.ics
	A			src/parser/calendar/ics/__tests__/data/err-unexpected-child.ics
	A			src/parser/calendar/ics/__tests__/data/err-unexpected-text.ics
	A			src/parser/calendar/ics/__tests__/data/good-boolean.ics
	A			src/parser/calendar/ics/__tests__/data/multiple-vcalendars.ics