Homec4science

Add a reflection-based unit test for subclasses increasing method visibility

Authored by Joshua Spence <josh@joshuaspence.com> on Jan 15 2015, 21:15.

Description

Add a reflection-based unit test for subclasses increasing method visibility

Summary: Ref T6822. We can't actually commit this until we fix all the violations mentioned in that task. Depends on D11231.

Test Plan:

  • Used code to identify violations.
  • Hit exception under arc unit --everything.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, joshuaspence, epriestley

Maniphest Tasks: T6822

Differential Revision: https://secure.phabricator.com/D11052

Details

Committed
Joshua Spence <josh@joshuaspence.com>Jan 15 2015, 21:41
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU5bb6e9a10714: Fix the visibility of `PhutilDaemon::run` methods
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rPHUf9d855ceb2fb: Add a reflection-based unit test for subclasses increasing method visibility (authored by Joshua Spence <josh@joshuaspence.com>).Jan 15 2015, 21:41