Homec4science

Make two-factor auth actually work

Authored by epriestley <git@epriestley.com> on Apr 28 2014, 19:20.

Description

Make two-factor auth actually work

Summary:
Ref T4398. Allows auth factors to render and validate when prompted to take a hi-sec action.

This has a whole lot of rough edges still (see D8875) but does fundamentally work correctly.

Test Plan:

  • Added two different TOTP factors to my account for EXTRA SECURITY.
  • Took hisec actions with no auth factors, and with attached auth factors.
  • Hit all the error/failure states of the hisec entry process.
  • Verified hisec failures appear in activity logs.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4398

Differential Revision: https://secure.phabricator.com/D8886

Details

Committed
epriestley <git@epriestley.com>Apr 28 2014, 19:20
Pushed
aubortJan 31 2017, 17:16
Parents
rPHbf6bda6ef481: Fix wording of "differential.sticky-accept"
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHa017a8e02b51: Make two-factor auth actually work (authored by epriestley <git@epriestley.com>).Apr 28 2014, 19:20