Homec4science

Fix an issue with `differential.getdiff` when providing a revision ID

Authored by epriestley <git@epriestley.com> on Sep 19 2013, 00:31.

Description

Fix an issue with differential.getdiff when providing a revision ID

Summary:
If handed a revision ID, we might get more than one result, which causes executeOne() to throw. Instead, translate the revision id into a diff ID before querying for the diff.

Also one small consistency change to parameter casing.

Test Plan: Used console to query for a revision with more than one diff using the revision id.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran, mbishopim3

Differential Revision: https://secure.phabricator.com/D7026

Details

Committed
epriestley <git@epriestley.com>Sep 19 2013, 00:31
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb1dfbda74113: Ponder - make feed stories and emails a bit better
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHa025050e87e0: Fix an issue with `differential.getdiff` when providing a revision ID (authored by epriestley <git@epriestley.com>).Sep 19 2013, 00:31