Homec4science

Audit - fix issue "showing older" on some commits

Authored by Bob Trahan <btrahan@phacility.com> on Jan 23 2015, 20:32.

Description

Audit - fix issue "showing older" on some commits

Summary: Fixes T7021. When I moved around all the timeline stuff I guess I didn't find this "corner" case, which is wildly common in the post-commit review workflow that we don't use.

Test Plan: pre-patch I could reproduce the issue and post patch I could not. The reproduction case is to have a commit with inline comments and then enough subsequent comments to have a "show older" UI. clicking "show older" now works!

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7021

Differential Revision: https://secure.phabricator.com/D11479

Details

Committed
Bob Trahan <btrahan@phacility.com>Jan 23 2015, 20:32
Pushed
aubortJan 31 2017, 17:16
Parents
rPH30eea5e93680: Resolve an issue with Diffusion URI parsing ignoring some information
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPHa03d16907c03: Audit - fix issue "showing older" on some commits (authored by Bob Trahan <btrahan@phacility.com>).Jan 23 2015, 20:32