Homec4science

Require TokenizerControl to always have a datasource

Authored by epriestley <git@epriestley.com> on Apr 18 2015, 17:38.

Description

Require TokenizerControl to always have a datasource

Summary:
Ref T4100. I can simplify the logic a bit here by moving some rendering into the datasources, but a few TokenizerControls currently don't have datasources.

Require datasources and always provide datasources.

Test Plan:

  • Used previously-datasourceless controls (e.g., "Add Reviewers").
  • Used normal controls.
  • Manually verified that no other controls are missing datasources.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4100

Differential Revision: https://secure.phabricator.com/D12456

Details

Committed
epriestley <git@epriestley.com>Apr 20 2015, 19:06
Pushed
aubortJan 31 2017, 17:16
Parents
rPHe27c0b416d45: Add "Edge Logic" support to PolicyAwareQuery
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHa11dab59b0d5: Require TokenizerControl to always have a datasource (authored by epriestley <git@epriestley.com>).Apr 20 2015, 19:06