Homec4science

Fix bad aspect ratio on some file previews

Authored by epriestley <git@epriestley.com> on May 12 2015, 17:30.

Description

Fix bad aspect ratio on some file previews

Summary: Ref T7707. Fixes T4724. I misread the report on T4724; this is trivial. We're just reading the wrong properties in setting "width" and "height" attributes, the actual thumbnailing logic is fine.

Test Plan: Uploaded image from T4724, saw it have a proper aspect ratio.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: spicyj, epriestley

Maniphest Tasks: T4724, T7707

Differential Revision: https://secure.phabricator.com/D12810

Details

Committed
epriestley <git@epriestley.com>May 13 2015, 20:38
Pushed
aubortJan 31 2017, 17:16
Parents
rPH65ff40844ba8: Make modular transforms handle exceptions gracefully
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHa19b0029e223: Fix bad aspect ratio on some file previews (authored by epriestley <git@epriestley.com>).May 13 2015, 20:38