Homec4science

Initial support for comments/append-edits in EditEngine

Authored by epriestley <git@epriestley.com> on Dec 2 2015, 20:10.

Description

Initial support for comments/append-edits in EditEngine

Summary:
Ref T9132. This just replaces the "Add Comment" form in Paste with a generic flow in EditEngine.

No actual field-awareness or action stacking or anything quite yet, but that will come in a bit. This mildly regresses drafts (which don't seem like a big deal for Pastes). I'll hook those up again in the next diff, but I want to build them in a better way that will work with multiple actions in a generic way, and solve T5031.

Big practical advantage here is that applications don't need copy/pasted preview controllers.

Test Plan:

  • Saw previews.
  • Added comments.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9132

Differential Revision: https://secure.phabricator.com/D14637

Details

Committed
epriestley <git@epriestley.com>Dec 3 2015, 16:06
Pushed
aubortJan 31 2017, 17:16
Parents
rPH274f115d41b2: Update Pholio to return Remarkup in Feed
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHa1c7ba6b8b29: Initial support for comments/append-edits in EditEngine (authored by epriestley <git@epriestley.com>).Dec 3 2015, 16:06