Homec4science

Implement rough content-aware inline adjustment rules for ghosts

Authored by epriestley <git@epriestley.com> on May 7 2015, 23:09.

Description

Implement rough content-aware inline adjustment rules for ghosts

Summary:
Ref T7447. Fixes T7600. This likely needs significant adjustment, but implements content-aware comment porting for line changes.

Specifically, this moves lines around to adjust their position considering added and removed lines between the diffs and across rebases.

It does not try to do any actual content (line against line) matching.

Test Plan:

  • Unit tests.
  • Poking around in the web UI seems to generate mostly reasonable-ish results?
  • This may be a huge step backward in some cases that I just haven't hit.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: yelirekim, epriestley

Maniphest Tasks: T7600, T7447

Differential Revision: https://secure.phabricator.com/D12741

Details

Committed
epriestley <git@epriestley.com>May 7 2015, 23:09
Pushed
aubortJan 31 2017, 17:16
Parents
rPH524aee03dca0: Conpherence - make sure real time updates still work if you switch threads
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHa238f6a7598a: Implement rough content-aware inline adjustment rules for ghosts (authored by epriestley <git@epriestley.com>).May 7 2015, 23:09