Homec4science

Prevent artifact key collision when builds are restarted

Authored by James Rhodes <jrhodes@redpointsoftware.com.au> on Aug 28 2014, 00:21.

Description

Prevent artifact key collision when builds are restarted

Summary: Ref T1049. Because we no longer destroy artifacts when builds are restarted, we need the build generation number to be part of the artifact key, otherwise we get collisions when restarting builds that contain build steps that emit artifacts.

Test Plan: Ran it with a build plan of "Lease Host" and "Run Command", no longer got an artifact key crash.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T1049

Differential Revision: https://secure.phabricator.com/D10336

Details

Committed
James Rhodes <jrhodes@redpointsoftware.com.au>Aug 28 2014, 00:21
Pushed
aubortJan 31 2017, 17:16
Parents
rPH0e15393b466e: Prevent crash when build step has been deleted on build plan
Branches
Unknown
Tags
Unknown

Event Timeline

James Rhodes <jrhodes@redpointsoftware.com.au> committed rPHa26c6147f537: Prevent artifact key collision when builds are restarted (authored by James Rhodes <jrhodes@redpointsoftware.com.au>).Aug 28 2014, 00:21