Homec4science

Fix two parsing issues for diffs with damaged whitespace

Authored by epriestley <git@epriestley.com> on May 4 2014, 19:48.

Description

Fix two parsing issues for diffs with damaged whitespace

Summary:
Fixes T4941. If a diff has had trailing whitespace stripped, we will fail to handle empty lines correctly (previously, these lines had a leading space when the original tool emitted them).

(This probably stopped working around the time we began retaining newlines.)

Test Plan: The diff in T4941 now parses and renders correctly.

Reviewers: asherkin, btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4941

Differential Revision: https://secure.phabricator.com/D8968

Details

Committed
epriestley <git@epriestley.com>May 4 2014, 19:48
Pushed
aubortJan 31 2017, 17:16
Parents
rPH58fbb0ae532f: Support mailto in Phabricator config defaults
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHa272ddcc7869: Fix two parsing issues for diffs with damaged whitespace (authored by epriestley <git@epriestley.com>).May 4 2014, 19:48