Homec4science

Draw project PHIDs from repositories when evaluating Herald object rules for…

Authored by epriestley <git@epriestley.com> on Jan 11 2017, 19:09.

Description

Draw project PHIDs from repositories when evaluating Herald object rules for commits

Summary:
Fixes T12097. In D16413, I simplified this code but caused us to load the commit's projects instead of the repository's projects, which is incorrect.

Normally, commits don't have any project tags when Herald evaluates, so using the commit's projects is generally meaningless.

Test Plan:

  • Tagged a repository with #X.
  • Created a Herald object rule for commits with #X as the object ("Always ... do nothing.")
  • Ran a commit from the repository.
  • Before patch: rule failed to evaluate.
  • After patch: rule evaluated and passed.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12097

Differential Revision: https://secure.phabricator.com/D17179

Details

Committed
epriestley <git@epriestley.com>Jan 11 2017, 19:29
Pushed
aubortJan 31 2017, 17:16
Parents
rPH7ff0be1bde2f: Bring very basic EditEngine support to commits
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHa27c824da67d: Draw project PHIDs from repositories when evaluating Herald object rules for… (authored by epriestley <git@epriestley.com>).Jan 11 2017, 19:29