Homec4science

Simplify comment highlight behavior in Pholio

Authored by epriestley <git@epriestley.com> on Feb 23 2013, 15:27.

Description

Simplify comment highlight behavior in Pholio

Summary:

  • Currently, we register this behavior every time we load comments. Instead, register it once.
  • We have two very similar behaviors for over/out. Just use one that does the right thing based on the event type.

Test Plan: Waved my mouse over areas of the image with reticles, saw the correct comments highlight.

Reviewers: chad, ljalonen

Reviewed By: chad

CC: aran

Differential Revision: https://secure.phabricator.com/D5082

Details

Committed
epriestley <git@epriestley.com>Feb 23 2013, 15:27
Pushed
aubortJan 31 2017, 17:16
Parents
rPH11f6e733280b: Fix bubbles on app launch buttons.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHa2abbd560a06: Simplify comment highlight behavior in Pholio (authored by epriestley <git@epriestley.com>).Feb 23 2013, 15:27