Homec4science

Log and continue when trying to destroy edges with no edge definition

Authored by epriestley <git@epriestley.com> on Jun 23 2016, 14:14.

Description

Log and continue when trying to destroy edges with no edge definition

Summary: Fixes T11201.

Test Plan:
Created bogus edges like this:

INSERT INTO edge (src, type, dst, dateCreated, seq) values ('PHID-TASK-vnddativbialb5p6ymis', 999999, 'quack', UNIX_TIMESTAMP(), 1);

Then ran bin/remove destroy on the relevant object.

Before the patch, destruction halted after hittin the bad edge.

After the patch, a warning is emitted but destruction continues.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11201

Differential Revision: https://secure.phabricator.com/D16171

Details

Committed
epriestley <git@epriestley.com>Jun 23 2016, 15:45
Pushed
aubortJan 31 2017, 17:16
Parents
rPH72588d2eaaa0: Allow device-to-device SSH to establish SSH sessions
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHa2cb5e134755: Log and continue when trying to destroy edges with no edge definition (authored by epriestley <git@epriestley.com>).Jun 23 2016, 15:45