Homec4science

Make query engines "overheat" instead of stalling when filtering too many…

Authored by epriestley <git@epriestley.com> on Oct 20 2016, 17:33.

Description

Make query engines "overheat" instead of stalling when filtering too many results

Summary: Ref T11773. This is an initial first step toward a more complete solution, but should make the worst case much less bad: prior to this change, the worst case was "30 second exeuction timeout". After this patch, the worst case is "no results + explanatory message", which is strictly better.

Test Plan:
Made all feed stories fail policy checks, loaded home page.

  • Before adding overheating: 9,600 queries / 20 seconds
  • After adding overheating: 376 queries / 800ms

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11773

Differential Revision: https://secure.phabricator.com/D16735

Details

Committed
epriestley <git@epriestley.com>Oct 20 2016, 18:31
Pushed
aubortJan 31 2017, 17:16
Parents
rPHa00e867de094: Hide footer on mobile Conpherence
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHa3253f78ce14: Make query engines "overheat" instead of stalling when filtering too many… (authored by epriestley <git@epriestley.com>).Oct 20 2016, 18:31