Track daemon unique IDs in Phabricator daemon logs
a354e5fa6b94
Actions

Authored by epriestley <git@epriestley.com> on Feb 23 2015, 20:26.

Description

Track daemon unique IDs in Phabricator daemon logs

Summary:
Ref T7352. We were previously identifying things by <daemonClass, overseerPID, startTime> but that's not unique in a world where one overseer can run multiple daemons.

We already have an internal "daemonID", it just doesn't get written into the DB right now.

Start writing it, then use it to clean up phd status.

Test Plan: Ran phd status, got more accurate/useful output than previously.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7352

Differential Revision: https://secure.phabricator.com/D11865

Details

Committed

epriestley <git@epriestley.com>

Feb 24 2015, 23:50

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPHef22fe1e743c: Add a --force command to `phd start`

Branches

Unknown

Tags

Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHa354e5fa6b94: Track daemon unique IDs in Phabricator daemon logs (authored by epriestley <git@epriestley.com>).Feb 24 2015, 23:50

Changes (9)

				Path
	A			resources/sql/autopatches/20150223.daemon.1.id.sql
	A			resources/sql/autopatches/20150223.daemon.2.idlegacy.sql
	A			resources/sql/autopatches/20150223.daemon.3.idkey.sql
	M			src/applications/daemon/event/PhabricatorDaemonEventListener.php
	M			src/applications/daemon/management/PhabricatorDaemonManagementStatusWorkflow.php
	M			src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php
	M			src/applications/daemon/query/PhabricatorDaemonLogQuery.php
	M			src/applications/daemon/storage/PhabricatorDaemonLog.php
	M			src/infrastructure/daemon/control/PhabricatorDaemonReference.php