Homec4science

Lift handling of Herald "email" effect to Adapter

Authored by epriestley <git@epriestley.com> on Apr 6 2015, 19:00.

Description

Lift handling of Herald "email" effect to Adapter

Summary:
Ref T7731. Every adapter subclass currently implements this effect in an essentially identical way.

Some day far from now the effects will be modular and this mess will vanish completely, but reduce its sprawl for now.

Test Plan: I'll test this thoroughly at the end of the change sequence since writing rules is a pain.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7731

Differential Revision: https://secure.phabricator.com/D12268

Details

Committed
epriestley <git@epriestley.com>Apr 6 2015, 19:00
Pushed
aubortJan 31 2017, 17:16
Parents
rPHe0edb0797c9f: Remove "effector" from HeraldAdapter
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHa40748a46cb5: Lift handling of Herald "email" effect to Adapter (authored by epriestley <git@epriestley.com>).Apr 6 2015, 19:00