Homec4science

Begin formalizing query orders

Authored by epriestley <git@epriestley.com> on Apr 11 2015, 21:10.

Description

Begin formalizing query orders

Summary:
Ref T7803. Queries currently have a single getPagingColumn(), which is oversimplified and insufficient to describe many ordering operations. Frequently, orders must span multiple columns.

Move toward an "order vector", which is a list of orderable values like "name, id". These map directly to columns, and are sufficient to actually describe orders. The more modern Query classes (Maniphest, Repository) essentially do this manually anyway.

Test Plan:

  • Added and executed unit tests.
  • Browsed around, verified the correct ORDER BY clauses were generated.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7803

Differential Revision: https://secure.phabricator.com/D12352

Details

Committed
epriestley <git@epriestley.com>Apr 13 2015, 20:58
Pushed
aubortJan 31 2017, 17:16
Parents
rPH9dc114d1159a: Make formatOrderClause() safer
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHa43473c4b65c: Begin formalizing query orders (authored by epriestley <git@epriestley.com>).Apr 13 2015, 20:58