Homec4science

Partially use ApplicationSearch in main search

Authored by epriestley <git@epriestley.com> on Feb 3 2014, 21:51.

Description

Partially use ApplicationSearch in main search

Summary:
Ref T4365. Primary search currently uses PhabricatorSearchQuery for storage, which is pretty much the same as PhabricatorSavedQuery, except that it's old and not used anywhere else anymore.

Maniphest used to also use this table, but no longer does after Septmeber, 2013. We need to retain the class so the migration can work.

This introduces PhabricatorSearchApplicationSearchEngine and PhabricatorSearchDocumentQuery, but they're both stubs that I just needed for technical reasons and/or to pass lint. The next couple patches will move logic into them and use ApplicationSearch properly.

Test Plan:

  • Searched for stuff.
  • Searched for stuff with filters.
  • Searched for fulltext in Maniphest.
  • Grepped for PhabricatorSearchQuery.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4365

Differential Revision: https://secure.phabricator.com/D8120

Details

Committed
epriestley <git@epriestley.com>Feb 3 2014, 21:51
Pushed
aubortJan 31 2017, 17:16
Parents
rPHe42a982445bc: When creating foreign stubs during SVN import, mark them imported
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHa48128d36fc6: Partially use ApplicationSearch in main search (authored by epriestley <git@epriestley.com>).Feb 3 2014, 21:51