Homec4science

Allow transactions to require read locks during edits

Authored by epriestley <git@epriestley.com> on Apr 5 2013, 00:16.

Description

Allow transactions to require read locks during edits

Summary:
Let applicationtransaction editors request locks when applying certain transactions. See D5567.

We should probably do this for all not-guaranteed-safe operations, but let's put our toe in the water with Conpherence first. I believe the cost of these locks is very small and my cautious stance toward acquiring them isn't really warranted, but I've also never seen, e.g., a race on a title edit.

Test Plan: Added comments with and without locks, verified both pathways worked correctly.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D5582

Details

Committed
epriestley <git@epriestley.com>Apr 5 2013, 00:16
Pushed
aubortJan 31 2017, 17:16
Parents
rPHd3020af97b92: Uniformized handle data
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHa56846e62a6e: Allow transactions to require read locks during edits (authored by epriestley <git@epriestley.com>).Apr 5 2013, 00:16