Homec4science

Share more code between tokenizers and global typeahead

Authored by epriestley <git@epriestley.com> on Jul 18 2014, 00:52.

Description

Share more code between tokenizers and global typeahead

Summary:
Ref T4420. Fixes T5306. Currently, the main menubar search has a lot of redundant/unshared code.

Move some common functions into JX.Prefab.whatever() and call them from the main search.

The major change here is that we apply the same "only show closed/disabled/archived objects if there are no matching open objects" logic, fixing T5306.

Test Plan:

  • Used normal typeaheads.
  • Used global search.
  • Searched for a prefix shared by open and archived projects, didn't see the archived ones until the open ones were exhausted.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T5306, T4420

Differential Revision: https://secure.phabricator.com/D9899

Details

Committed
epriestley <git@epriestley.com>Jul 18 2014, 00:52
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc52b3c28e166: Remove partial objects from Lisk
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHa592b32ca4b9: Share more code between tokenizers and global typeahead (authored by epriestley <git@epriestley.com>).Jul 18 2014, 00:52