Homec4science

Modernize Releeph "Product Activate" controller

Authored by epriestley <git@epriestley.com> on Mar 29 2014, 17:14.

Description

Modernize Releeph "Product Activate" controller

Summary:
Ref T3549. A few things here:

  • Releeph has an object called a "Project". We'd like to call this a "Product" instead. See T3549. Rename easy instances that don't break URIs.
  • Releeph has a "ProjectController" which tries to be smart about loading objects. However, it's big and messy and doesn't have the finesse to do policies or needX(...) correctly. It also generates URIs which collide with one another. Introduce "ProductController" to start to move away from it.
  • Some small modernizations to this controller to take advantage of newer infrastructure (like easier dialog rendering).

Test Plan: Deactivated and reactivated products.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T3549

Differential Revision: https://secure.phabricator.com/D8632

Details

Committed
epriestley <git@epriestley.com>Mar 29 2014, 17:14
Pushed
aubortJan 31 2017, 17:16
Parents
rPH6c8cef3bee35: Remove ReleephUserView
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHa5ad923573fd: Modernize Releeph "Product Activate" controller (authored by epriestley <git@epriestley.com>).Mar 29 2014, 17:14