Homec4science

Provide convenience method addTextCrumb() to PhabricatorCrumbsView

Authored by epriestley <git@epriestley.com> on Dec 19 2013, 02:47.

Description

Provide convenience method addTextCrumb() to PhabricatorCrumbsView

Summary: We currently have a lot of calls to addCrumb(id(new PhabricatorCrumbView())->...) which can be expressed much more simply with a convenience method. Nearly all crumbs are only textual.

Test Plan:

  • This was mostly automated, then I cleaned up a few unusual sites manually.
  • Bunch of grep / randomly clicking around.

Reviewers: btrahan, chad

Reviewed By: btrahan

CC: hach-que, aran

Differential Revision: https://secure.phabricator.com/D7787

Details

Committed
epriestley <git@epriestley.com>Dec 19 2013, 02:47
Pushed
aubortJan 31 2017, 17:16
Parents
rPHdc43123494df: Get the proper Subversion URI for hosted repositories.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHa5dc9067af0c: Provide convenience method addTextCrumb() to PhabricatorCrumbsView (authored by epriestley <git@epriestley.com>).Dec 19 2013, 02:47