Homec4science

Allow Passphrase to store empty secrets

Authored by epriestley <git@epriestley.com> on Sep 4 2014, 21:48.

Description

Allow Passphrase to store empty secrets

Summary: Fixes T6001. We currently don't allow empty secrets, but accounts with no password are occasionally used in the wild.

Test Plan:

  • Created a credential with an empty secret.
  • Revealed secret, saw empty message.
  • Edited it (no form changes), saw secret unchanged.
  • Changed it to a nonempty secret.
  • Revealed nonempty secret.
  • Edited it (no form changes), saw secret unchanged.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T6001

Differential Revision: https://secure.phabricator.com/D10414

Details

Committed
epriestley <git@epriestley.com>Sep 4 2014, 21:48
Pushed
aubortJan 31 2017, 17:16
Parents
rPH4d3cc7b28dd1: Use %s, not %d, to encode a 64-bit integer for a query
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHa6296a64a457: Allow Passphrase to store empty secrets (authored by epriestley <git@epriestley.com>).Sep 4 2014, 21:48