Homec4science

Link manual diff from lint error displayed at commit diff

Authored by vrana <jakubv@fb.com> on Aug 18 2012, 02:46.

Description

Link manual diff from lint error displayed at commit diff

Summary:
Some fields require displayed diff (e.g. Lines), some require last manual diff (Lint, Unit).
Lint requires both - it needs to find if the line with the error is displayed or not.

Test Plan: Displayed committed diff with lint errors, clicked on them, got last manual diff at the correct line.

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3331

Details

Committed
vrana <jakubv@fb.com>Aug 30 2012, 22:43
Pushed
aubortJan 31 2017, 17:16
Parents
rPH17524352551c: Display away data in revision fields
Branches
Unknown
Tags
Unknown

Event Timeline

vrana <jakubv@fb.com> committed rPHa64f5b01486a: Link manual diff from lint error displayed at commit diff (authored by vrana <jakubv@fb.com>).Aug 30 2012, 22:43