Homec4science

Start of a config web interface.

Authored by Ricky Elrod <ricky@elrod.me> on Dec 28 2012, 00:20.

Description

Start of a config web interface.

Summary:
This is somewhat clowny, particularly in how it handles JSON encode/decode, but
I've commented why I did things the way I did. The goal is to store minified JSON
but show pretty-printed JSON where possible, to the user editing it.

Test Plan:

  • Went to /config/ and saw a list of keys from the default config.
  • Clicked on one of them, submitted the default value successfully.
  • Changed the value to invalid JSON and got a decent error.
  • Changed the value to valid JSON and checked the DB to confirm it saved.
  • Confirmed the DB values were minified.
  • Confirmed the user-facing values were pretty-printed where they could be.
  • Confirmed that PHIDs were getting assigned properly and that isDeleted properly defaulted to false/0.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2246

Differential Revision: https://secure.phabricator.com/D4290

Details

Committed
epriestley <git@epriestley.com>Dec 28 2012, 00:21
Pushed
aubortJan 31 2017, 17:16
Parents
rPH1e2dfb5b6b7a: Minor, prevent double-initialization of EventEngine. This happens in…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHa774620042c1: Start of a config web interface. (authored by Ricky Elrod <ricky@elrod.me>).Dec 28 2012, 00:21