Homec4science

Conpherence - fix policy bug on comments with files in rooms

Authored by Bob Trahan <btrahan@phacility.com> on Apr 17 2015, 01:15.

Description

Conpherence - fix policy bug on comments with files in rooms

Summary: Fixes T7840. Add some unit tests. One explicitly covers the case in T7840. Other cases are "base" cases for rooms and threads, plus the version if T7840 for a thread, where a policy exception should be thrown.

Test Plan: arc unit and was able to successfully add a file to a conpherence room i did not have edit permissions on

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7840

Differential Revision: https://secure.phabricator.com/D12443

Details

Committed
Bob Trahan <btrahan@phacility.com>Apr 17 2015, 01:15
Pushed
aubortJan 31 2017, 17:16
Parents
rPHd59ef485ec9f: Fix text area width on mobile conpherence
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPHa81072046a28: Conpherence - fix policy bug on comments with files in rooms (authored by Bob Trahan <btrahan@phacility.com>).Apr 17 2015, 01:15