Homec4science

Allow Maniphest queries to have configurable page sizes

Authored by epriestley <git@epriestley.com> on Sep 13 2013, 17:44.

Description

Allow Maniphest queries to have configurable page sizes

Summary:
Current page size is 1000. This is nice to have in some cases, but makes pages slower than necessary in others. Task lists are generally dominated by rendering costs.

For example, my default is "recent tasks", which just lists all tasks ordered by date created. Showing 100 tasks here instead of 1000 makes this several times faster without compromising utility.

I don't want to force the default to 100, though, since sometimes listing everything is quite useful and I think an advantage of Maniphest is that it generally deals reasonably well with large task sets.

(This limit property is actually read by the default implementation of getPageSize() in the parent class.)

Test Plan: Made queries with page sizes 1, 100, 12, 9, 3000, etc.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D6976

Details

Committed
epriestley <git@epriestley.com>Sep 13 2013, 20:49
Pushed
aubortJan 31 2017, 17:16
Parents
rPH62e66e3cf6c1: Completely implement cursor paging in Maniphest
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHa82c3a89144e: Allow Maniphest queries to have configurable page sizes (authored by epriestley <git@epriestley.com>).Sep 13 2013, 20:49