Homec4science

Allow configuration to be explicitly validated, including validation of complex…

Authored by epriestley <git@epriestley.com> on Jan 2 2013, 03:15.

Description

Allow configuration to be explicitly validated, including validation of complex attributes

Summary:

  • Allows us to implement setup warnings for edits which don't go through the web UI, e.g. "you edited a config file and set value X to something goofy".
  • Allows us to implement more sophisticated validations, beyond basic type checks (e.g., "phabricator.base-uri" must be a URI).
  • Fixes T358 (or, close enough -- fixes it for all options which have been migrated as per T2255.

Test Plan: Set "darkconsole.enabled" to "xyz" in my config, observed setup warning. Added fake validation, observed web UI edit error.

Reviewers: codeblock, btrahan

Reviewed By: codeblock

CC: aran

Maniphest Tasks: T2255, T358

Differential Revision: https://secure.phabricator.com/D4315

Details

Committed
epriestley <git@epriestley.com>Jan 2 2013, 03:15
Pushed
aubortJan 31 2017, 17:16
Parents
rPH32e4a7a37f1f: Use transactions to show edit history for Configuration
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHa86fd38394e5: Allow configuration to be explicitly validated, including validation of complex… (authored by epriestley <git@epriestley.com>).Jan 2 2013, 03:15