Homec4science

Fix an issue with tail parsing in object embeds in remarkup

Authored by epriestley <git@epriestley.com> on Dec 2 2014, 03:48.

Description

Fix an issue with tail parsing in object embeds in remarkup

Summary:
Fixes T6619. In {Xnnn key=value, key=value} we did not require a separator between the object and the key-value part. This could lead to {rX11aaa} being parsed as {rX11 aaa}, i.e. a reference to rX11 with parameter aaa set.

Instead, require a space or comma before we'll parse key-value parts of embedded objects.

Test Plan:
Added and executed unit tests.

{F242002}

Reviewers: chad, btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T6619

Differential Revision: https://secure.phabricator.com/D10915

Details

Committed
epriestley <git@epriestley.com>Dec 2 2014, 03:48
Pushed
aubortJan 31 2017, 17:16
Parents
rPH1716861ad8ee: Differential - fix bug destroying diffs
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHa8be733e5ffe: Fix an issue with tail parsing in object embeds in remarkup (authored by epriestley <git@epriestley.com>).Dec 2 2014, 03:48