Homec4science

Infrastructure changes to support scoped symbols

Authored by Alan Huang <alanh@fb.com> on Aug 7 2012, 18:28.

Description

Infrastructure changes to support scoped symbols

Summary:

  • import_project_symbols supports an optional extra field, which is the context of the symbol.
  • Symbol query can take a symbol argument, either as a parameter or a URL component (so you can now jump nav to s Zerg/rush, for example).
  • Conduit method not yet updated. Will do that later.
NOTE: Not providing a context is distinct from providing an empty context, because an empty context stands for top-level context, i.e. functions and classes for PHP. It will not find class methods, etc. It is possible that we should use some weird token that could not normally be a context name to stand in for empty context.

Test Plan: Do a bunch of symbol searches.

Reviewers: epriestley

Reviewed By: epriestley

CC: nh, aran, Korvin

Maniphest Tasks: T1602

Differential Revision: https://secure.phabricator.com/D3148

Details

Committed
Alan Huang <alanh@fb.com>Aug 7 2012, 18:28
Pushed
aubortJan 31 2017, 17:16
Parents
rPH1c98ca70420a: Fix doc links
Branches
Unknown
Tags
Unknown

Event Timeline

Alan Huang <alanh@fb.com> committed rPHa8d6af0f42a8: Infrastructure changes to support scoped symbols (authored by Alan Huang <alanh@fb.com>).Aug 7 2012, 18:28