Use PhutilQueryCompiler in Phabricator fulltext search
a9560479894f
Actions

Authored by epriestley <git@epriestley.com> on Nov 24 2016, 17:13.

Description

Use PhutilQueryCompiler in Phabricator fulltext search

Summary:
Ref T11741. Fixes T10642. Parse and compile user queries with a consistent ruleset, then submit queries to the backend using whatever ruleset MySQL is configured with.

This means that ft_boolean_syntax no longer needs to be configured (we'll just do the right thing in all cases).

This should improve behavior with RDS immediately (T10642), and allow us to improve behavior with InnoDB in the future (T11741).

Test Plan:

Ran various queries in the UI, saw the expected results.
Ran bad queries, got useful errors.
Searched threads in Conpherence.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10642, T11741

Differential Revision: https://secure.phabricator.com/D16939

Details

Committed

epriestley <git@epriestley.com>

Nov 25 2016, 23:46

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPHeac49e421a41: Fix an issue where an excessively long TTL was computed for "not attending…

Branches

Unknown

Tags

Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHa9560479894f: Use PhutilQueryCompiler in Phabricator fulltext search (authored by epriestley <git@epriestley.com>).Nov 25 2016, 23:46

Changes (5)

				Path
	M			src/applications/config/check/PhabricatorMySQLSetupCheck.php
	M			src/applications/conpherence/query/ConpherenceFulltextQuery.php
	M			src/applications/search/controller/PhabricatorApplicationSearchController.php
	M			src/applications/search/fulltextstorage/PhabricatorMySQLFulltextStorageEngine.php
	M			src/applications/search/storage/document/PhabricatorSearchDocument.php