Homec4science

Transactions - don't bother checking for fancy transactions on comment create

Authored by Bob Trahan <btrahan@phacility.com> on Dec 4 2014, 21:04.

Description

Transactions - don't bother checking for fancy transactions on comment create

Summary: Only necessary for edits, only bother if the comment version is greater than 1. Ref T6690. This is another way to fix T6690 -- this check will never run since you can't edit a conpherence comment -- but the fix already applied should happen too to future proof Conpherence.

Test Plan: made a comment on a diff - success. edited the comment and mentions were generated.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6690

Differential Revision: https://secure.phabricator.com/D10928

Details

Committed
Bob Trahan <btrahan@phacility.com>Dec 4 2014, 21:04
Pushed
aubortJan 31 2017, 17:16
Parents
rPH49e53d5709da: Conpherence - fix permissions issue creating new Conpherences
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPHa9f0bd9b8fbf: Transactions - don't bother checking for fancy transactions on comment create (authored by Bob Trahan <btrahan@phacility.com>).Dec 4 2014, 21:04