Homec4science

Simplify Herald logic for loading Differential changes

Authored by epriestley <git@epriestley.com> on Apr 14 2014, 21:06.

Description

Simplify Herald logic for loading Differential changes

Summary: Ref T4045. These three methods are fairly copy-pastey. Provide a more formal DifferentialHunk API for querying various types of line ranges.

Test Plan: Used test console to verify that "added content", "removed content", and "changed content" rules still produce the same data.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4045

Differential Revision: https://secure.phabricator.com/D8764

Details

Committed
epriestley <git@epriestley.com>Apr 14 2014, 21:06
Pushed
aubortJan 31 2017, 17:16
Parents
rPH2509c6b0f57d: Fixing z-index on calendar date badges.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHaaf1320b02cf: Simplify Herald logic for loading Differential changes (authored by epriestley <git@epriestley.com>).Apr 14 2014, 21:06