Homec4science

Don't require working copy to generate URIs in owners tool

Authored by Nick Harper <nharper@fb.com> on Sep 7 2012, 05:38.

Description

Don't require working copy to generate URIs in owners tool

Summary:
Owners packages might include repositories that are no longer tracked
(or checked out locally), and there's no reason why we need a working copy
to generate a diffusion link. Instead of displaying a red error box, this
diff allows the owners tool to render correctly.

Test Plan:
viewed /owners/view/all/ and /owners/package/395/ and verified no error box
for not having a checkout of the repository.

Reviewers: epriestley, vrana, wez

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3452

Details

Committed
Nick Harper <nharper@fb.com>Sep 7 2012, 05:38
Pushed
aubortJan 31 2017, 17:16
Parents
rPH90b60bc3c9a5: Load relationships for revision
Branches
Unknown
Tags
Unknown

Event Timeline

Nick Harper <nharper@fb.com> committed rPHab01ef562e8e: Don't require working copy to generate URIs in owners tool (authored by Nick Harper <nharper@fb.com>).Sep 7 2012, 05:38