Homec4science

Allow Almanac properties to be deleted, use EditEngine instead of CustomField

Authored by epriestley <git@epriestley.com> on Feb 22 2016, 15:35.

Description

Allow Almanac properties to be deleted, use EditEngine instead of CustomField

Summary:
Fixes T10410. Immediate impact of this is that you can now actually delete properties from Almanac services, devices and bindings.

The meat of the change is switching from CustomField to EditEngine for most of the actual editing logic. CustomField creates a lot of problems with using EditEngine for everything else (D15326), and weird, hard-to-resolve bugs like this one (not being able to delete stuff).

Using EditEngine to do this stuff instead seems like it works out much better -- I did this in ProfilePanel first and am happy with how it looks.

This also makes the internal storage for properties JSON instead of raw text.

Test Plan:

  • Created, edited and deleted properties on services, devices and bindings.
  • Edited and reset builtin properties on repository services.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10410

Differential Revision: https://secure.phabricator.com/D15327

Details

Committed
epriestley <git@epriestley.com>Feb 22 2016, 20:28
Pushed
aubortJan 31 2017, 17:16
Parents
rPH411331469af4: Apply namespace locking rules in Almanac
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHab86523ac490: Allow Almanac properties to be deleted, use EditEngine instead of CustomField (authored by epriestley <git@epriestley.com>).Feb 22 2016, 20:28